Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Remove all slice indexing in Plaintext and Record from console and circuit #1472

Open
howardwu opened this issue Apr 16, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@howardwu
Copy link
Contributor

🐛 Bug Report

Remove all slice indexing in Plaintext and Record from console and circuit.

There are many indices accessed directly instead of calling .get() which can cause unintentional panics (no it is not from poor engineering) when decrypting records that don't belong to the caller.

Note: in the real-world this case will not be hit, as the scanner is designed to first check if .is_owner() before calling .decrypt(). The lack of the owner check in decrypt was originally made to significantly reduce the runtime cost.

@howardwu howardwu added the bug Something isn't working label Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant