Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the engine features with the right value #553

Closed
Popov72 opened this issue Dec 22, 2020 · 2 comments
Closed

Update the engine features with the right value #553

Popov72 opened this issue Dec 22, 2020 · 2 comments
Milestone

Comments

@Popov72
Copy link

Popov72 commented Dec 22, 2020

From an email sent to Gary:

I forgot to say when merging the WebGPU changes to the master branch that I added a new EngineFeature property to the engine, which basically replaces all the occurrences of engine.webGLVersion that were used for testing purposes by a test in the feature property. For the time being, all the features are false for native engine as I didn't know what the right value would be.

So, that's something you (or someone else in the Native team) will need to update to match the capabilities of the engine. There's a comment for each capability in the engineFeatures.ts file, but feel tree to ask me if something is not clear.

@bghgary
Copy link
Contributor

bghgary commented Apr 21, 2022

This is to correctly set the engine._caps from the native side.

@bghgary
Copy link
Contributor

bghgary commented Sep 5, 2024

This is similar and basically a dupe of #1163

@bghgary bghgary closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants