Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace usage of surf with lighter-weight http-client #287

Closed
Voxelot opened this issue Apr 27, 2022 · 6 comments
Closed

replace usage of surf with lighter-weight http-client #287

Voxelot opened this issue Apr 27, 2022 · 6 comments

Comments

@Voxelot
Copy link
Member

Voxelot commented Apr 27, 2022

surf is bloated with an unmaintained dependency graph containing many security warnings. We should replace it with a lighter-weight solution such as reqwest or hyper.

It should also use rustls or some other non-openssl dependency.

@Voxelot
Copy link
Member Author

Voxelot commented Apr 29, 2022

We can't migrate to reqwest since openssl dependencies are being enabled by the graphql client extension framework cynic. Once they release this pr (obmarg/cynic#411), we'll be able to use reqwest without depending on openssl.

@adlerjohn
Copy link
Contributor

@Voxelot Cynic seems to be taking its sweet time releasing v2. Would it be worth it to fork it and release a forked cynic we can use ourselves?

@Voxelot
Copy link
Member Author

Voxelot commented May 31, 2022

Cynic is composed of many libraries, so an alternative is to only use its querygen crate, and wrap it with our own HTTP client.

@adlerjohn
Copy link
Contributor

Note: http-rs/http-client#98

@xgreenx
Copy link
Collaborator

xgreenx commented Dec 2, 2022

@Voxelot I guess we can close this issue because of #786 ?

@Voxelot
Copy link
Member Author

Voxelot commented Dec 2, 2022

yep!

@Voxelot Voxelot closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants