Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Remove obsolete encoder_only arguments from model definitions #68

Open
2 of 6 tasks
laserkelvin opened this issue Nov 17, 2023 · 0 comments
Open
2 of 6 tasks
Labels
enhancement New feature or request models Issues related to existing or new model implementations

Comments

@laserkelvin
Copy link
Collaborator

Feature/behavior summary

With #67, model forward methods are expected to output Embeddings objects, which doesn't leave room for ambiguity on what the model outputs are since the output heads from tasks are meant to do the final projections.

Request attributes

  • Would this be a refactor of existing code?
  • Does this proposal require new package dependencies?
  • Would this change break backwards compatibility?
  • Does this proposal include a new model?
  • Does this proposal include a new dataset?
  • Does this proposal include a new task/workflow?

Related issues

#67 is where this was brought up by @melo-gonzo, based on the model output refactors.

Solution description

Remove encoder_only arguments from models that have them, and any associated projection layers in models that won't be used.

Additional notes

No response

@laserkelvin laserkelvin added enhancement New feature or request models Issues related to existing or new model implementations labels Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request models Issues related to existing or new model implementations
Projects
None yet
Development

No branches or pull requests

1 participant