Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES Modules #39

Open
lastmjs opened this issue Apr 24, 2018 · 8 comments
Open

ES Modules #39

lastmjs opened this issue Apr 24, 2018 · 8 comments

Comments

@lastmjs
Copy link

lastmjs commented Apr 24, 2018

Can we move the element to being loaded through an ES Module instead of HTML imports? I'm happy to do the work and make the PR if I can get the go-ahead

@kkimdev
Copy link

kkimdev commented Jun 11, 2018

@lastmjs Hi I noticed your ES6-modules work-in-progress branch https://github.com/Juicy/juicy-ace-editor/compare/ES6-modules . Was there any issue with that?

@lastmjs
Copy link
Author

lastmjs commented Jun 12, 2018

Hey, you can see where that went here: #41 I've handed over the reins.

@kkimdev
Copy link

kkimdev commented Jun 12, 2018

Oh, I see, thanks!

@rjcorwin
Copy link

Related -> ajaxorg/ace#3682

@rjcorwin
Copy link

Using the es6 branch of this module with a bundler like Polymer's or Angular's I'm able to get syntax highlighting working by copying an ace build directories. This is makes for really messy looking builds but it works.

@MethodGrab
Copy link

It looks like Chrome is actually planning to remove HTML Import support soon. Pages with HTML Imports on have this console warning:

[Deprecation] HTML Imports is deprecated and will be removed in M73, around March 2019. Please use ES modules instead. See https://www.chromestatus.com/features/5144752345317376 for more details.

image

@simonh1000
Copy link

Would appreciate an update here as I'm not sure what is the recommended way to approach the Chrome deprecation warning

@warpech
Copy link
Contributor

warpech commented Mar 25, 2019

Current work in progress PR: #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants