Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using maxLines: Infinity as default #46

Open
tomalec opened this issue Jun 1, 2018 · 1 comment
Open

Consider using maxLines: Infinity as default #46

tomalec opened this issue Jun 1, 2018 · 1 comment

Comments

@tomalec
Copy link
Member

tomalec commented Jun 1, 2018

Steps to reproduce

Use <juicy-ace-editor> without any CSS nor attributes

Live Demo

https://jsbin.com/qodiqep/3/edit?html,css,output

Expected result

UX and DevX of the editor should be pleasing

Actual result

It's single line, does not expand when you type more lines, making it hard to read.
Requires some manual setup work to change it (CSS styles, attributes, etc.)

Browsers affected

all

Screenshot

image

Discovered by @alshakero
#45 (comment)

@alshakero
Copy link
Contributor

I agree with this comment #45 (comment). I thought Infinity meant as large as the container can fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants