Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger #65

Open
ablaom opened this issue Jul 22, 2024 · 0 comments
Open

Add logger #65

ablaom opened this issue Jul 22, 2024 · 0 comments

Comments

@ablaom
Copy link
Member

ablaom commented Jul 22, 2024

To close JuliaAI/MLJ.jl#1029.

This will be very similar to what we did for MLJTuning in these two PRs:

That is: We add a logger field to the wrapper structs (there are two of them - ProbabilisticTunedModel and DeterministicTunedModel ) just like we did for TunedModel. And then we pass logger on to the Resampler instances , which in this case appears here. In this way, whenever any iteration control (e.g., WithLossDo) accesses a loss, it will also get logged to the specified logger.

Instead of nothing the default value of logger will be MLJBase.default_logger().

cc @pebeto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant