Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic tag type selection for "Gap" and "Box" components #234

Open
3 tasks
tom-leamon opened this issue Dec 20, 2023 · 0 comments
Open
3 tasks

Add dynamic tag type selection for "Gap" and "Box" components #234

tom-leamon opened this issue Dec 20, 2023 · 0 comments

Comments

@tom-leamon
Copy link
Contributor

The "Gap" and "Box" components in the project are frequently used for layout purposes. Currently, these components are limited to certain tag types (like div). However, there are scenarios where it would be more semantically appropriate or functionally beneficial to use different tag types, such as ul or aside. Implementing dynamic tag type selection for these components would enhance their flexibility and semantic correctness in different contexts.

Action items:

  • Update the "Gap" component to accept a prop for selecting the HTML tag type.
  • Update the "Box" component to accept a prop for selecting the HTML tag type.
  • Ensure that the default tag type remains div
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant