Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reseting functionality #2

Open
tomalec opened this issue Jul 25, 2016 · 0 comments
Open

Improve reseting functionality #2

tomalec opened this issue Jul 25, 2016 · 0 comments

Comments

@tomalec
Copy link
Member

tomalec commented Jul 25, 2016

As a part of Palindrom/Palindrom#90 reset method was implemented, it takes initial object and entire new JSON, to convert it into JSON Patch to be applied.

I think as we are using JSON Patch communication over WebSocket, reset (if possible) should also be communicated with JSON Patch:

[
    {op: "replace", path: "/server/sender/version", value: 7},
    {op: "replace", path: "", value: entireJSONTree}
]

As that is exactly what we need.

"Set sender's version to given - regardless of queue or any existing version"
"Replace your outdated tree, with new one, entirely"

@chrhol, @warpech WDYT?

@chrhol I will need your support in making Starcounter respond such way for /reconnect request

@warpech warpech added this to the Palindrom stability milestone Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants