Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acceptNotification more consistency in response method #21

Open
judgej opened this issue Apr 25, 2017 · 0 comments
Open

acceptNotification more consistency in response method #21

judgej opened this issue Apr 25, 2017 · 0 comments

Comments

@judgej
Copy link
Member

judgej commented Apr 25, 2017

The object returned by acceptNotification is a server request incoming from the gateway. The Omnipay core documentation does not suggest any standard ways to acknowledge the notification. At the moment this involves using $request->send() to get a response object, and then $response->acknowledge() to return and acknowledgement and then immediately exit.

Instead, it makes more sense to return a HTTP response that can then be used in the response by the merchant site when it is ready. That response can include a body, headers and a specific HTTP code as appropriate to the state of the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant