Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matchers are overzealous #501

Open
5 tasks
hoshsadiq opened this issue Sep 12, 2024 · 1 comment
Open
5 tasks

Matchers are overzealous #501

hoshsadiq opened this issue Sep 12, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@hoshsadiq
Copy link

hoshsadiq commented Sep 12, 2024

Description:
The matcher ^\s*(.+\.go):(?:(\d+):(\d+):)? (.*) is way too broad (see regex101).

We are using go-generate-fast which outputs the results at the end of a go generate command as follows:

options.go: echo hello! (generated, noplugin, 2ms)

This gets caught by the matcher.

Action version:
latest

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:

Repro steps:
A description with steps to reproduce the issue. If your have a public example or repo to share, please provide the link.

Expected behavior:
It should not be matching non-errors that start with filename.go:

Actual behavior:
It is matching non-errors that start with filename.go:

It would be great to be able to disable the matchers in some way.

@hoshsadiq hoshsadiq added bug Something isn't working needs triage labels Sep 12, 2024
@aparnajyothi-y
Copy link

Hello @hoshsadiq, Thank you for creating this issue and we will look into it :)

@aparnajyothi-y aparnajyothi-y self-assigned this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants