Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on closed PRs #39368

Closed
mbhall88 opened this issue Feb 15, 2023 · 3 comments
Closed

Clarification on closed PRs #39368

mbhall88 opened this issue Feb 15, 2023 · 3 comments

Comments

@mbhall88
Copy link
Contributor

I'm wondering if I am doing something wrong with autobump PRs.

I release a new version of my package, and an autobump PR was created #39345

However, I added a new dependency. So I edited the meta.yaml file in that PR. When the tests all passed, I approved the PR and then asked biocondabot to merge it. But it responded "I received an error uploading the build artifacts or merging the PR!"

I then tried updating the PR with the tip of master. After the CI passed again, bicondabot closed the PR!

I then had the same problem again #39348

I've closed the most recent one #39364 and added a manual update myself #39367

What is the correct process in this example? It's happened to me before with other packages.

  1. It would be helpful if the bot gave some details of the error when trying to merge
  2. should I only update the PR with master using the bioconda bot command? (i.e. don't click "update branch" myself)
@daler
Copy link
Member

daler commented Feb 26, 2023

@mbhall88 this is unfortunately a known issue with the autobump bot. It's frustrating, we hope to fix it soon! You're not doing anything wrong, we need to be better about the bot behavior and also document the process better. The manual update is currently the best workaround.

@daler
Copy link
Member

daler commented Mar 2, 2023

@mbhall88 this problematic, inappropriate closing should now be fixed as of earlier today, but please reopen if you notice it happening again.

@daler daler closed this as completed Mar 2, 2023
@marcelm
Copy link
Contributor

marcelm commented Mar 18, 2023

@daler I just stumbled over this issue by accident. I’ve had this problem before and am happy to see that it should be solved. I’d just like to suggest that fixes like these deserve an announcement in some way, perhaps by posting to #33333.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants