Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store snapshot of adblock lists during adblock list build and update #884

Open
ShivanKaul opened this issue Apr 2, 2024 · 1 comment
Open
Assignees

Comments

@ShivanKaul
Copy link
Collaborator

ShivanKaul commented Apr 2, 2024

We are now downloading adblock lists to https://github.com/brave-experiments/adblock-lists-mirror/tree/lists/lists (after https://github.com/brave/devops/issues/11115). Next step would be to start using these downloaded lists instead of freshly downloading them as part of the build process.

EDIT: See comment below for better approach.

@ShivanKaul
Copy link
Collaborator Author

ShivanKaul commented Jul 30, 2024

@antonok-edm came up with a better approach:

  1. Download the lists during build time like usual
  2. Validate like usual
  3. Commit the new lists into https://github.com/brave-experiments/adblock-lists-mirror/commits/lists/lists
  4. Use and ship the lists as usual

Now, if we want to find out what the lists looked like after a specific component update, we can find the adblock-lists-mirror commit associated to that build run.

@ShivanKaul ShivanKaul changed the title Use downloaded adblock lists instead of fetching them during build time Store snapshot of adblock lists during adblock list build and update Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants