Bump clients to v0.7.1

[elezar]

The following clients need to be updated to use https://github.com/cncf-tags/container-device-interface/releases/tag/v0.7.1

Note the deprecated APIs.

• podman (@elezar)
  • common: fix(deps): update module tags.cncf.io/container-device-interface to v0.7.0 containers/common#1944
  • podman: Bump tags.cncf.io/container-device-interface to v0.7.1 containers/podman#22280
• docker (@elezar):
  • Daemon: Update tags.cncf.io/container-device-interface to v0.7.1 moby/moby#47706
  • CLI:
• containerd (@bart0sh)
  • main: Bump tags.cncf.io/container-device-interface to v0.7.1 containerd/containerd#10041
  • release-1.7: [release/1.7] Bump tags.cncf.io/container-device-interface to v0.7.2 containerd/containerd#10077
• crio (@klihub):
  • release-1.30:
  • main:
• singularity (@elezar)
  *
• ctr (@elezar)
• nerdctl (@elezar)
  • Add support for CDI devices to device flag containerd/nerdctl#2280 needs to be updated
• [ ] kubernetes (@bart0sh)

[kannon92]

What is required for CRIO?

[elezar]

@kannon92 we need to bump the dependencies and (optionally) move from the deprecated APIs. The containerd PR should be similar enough to be used as a guideline.

[kannon92]

I’ll see about doing it next week and I’ll cherry pick it to 1.30.

we are in the process of bumping a lot of dependencies right now with recent podman release.

[kannon92]

@klihub got to it already.

cri-o/cri-o#7971

[kannon92]

How important is this for 1.30?

There is a very unlikely chance this will go into k8s 1.30.

CRI-O 1.30 branch aims to be 1on1 with k8s 1.30.

[bart0sh]

@kannon92 I don't think it's important as most of changed functionality makes sense only for runtimes.

[kannon92]

I did a quick search into kubernetes but didn't see that cdi is a dependency.

[elezar]

Kubernetes doesn't depend on the spec at all. It should only be forwarding the cdi device names as opaque strings. There is some logic around constructing the container annotations (if required) that may be shareable, but I don't believe we pull anything in for that. There were concerns about dependencies at some point and the relevant logic was duplicated instead.

[bart0sh]

It will depend on CDI spec soon. It's in my short term TODO list.

So far there are two places in the k/k code that would benefit from it:

• this file should be removed. and this code should use imported CDI spec
• this code should also use imported CDI spec

[kannon92]

@klihub @elezar thank you for your patience on the crio work. We had some long lasting bugs around our CI images. this actually helped get a PR I had sitting for a few months also so it is greatly apprechiated!

You can mark the crio ones as complete. We will fast forward main into release-1.30 as we have not yet kicked off the release for crio 1.30.

[klihub]

@klihub @elezar thank you for your patience on the crio work. We had some long lasting bugs around our CI images. this actually helped get a PR I had sitting for a few months also so it is greatly apprechiated!

Thank for all your help with this, too !

[github-actions]

This issue is stale because it has been open 90 days with no activity. This issue will be closed in 30 days unless new comments are made or the stale label is removed.

[kannon92]

@bart0sh (bumping to keep this open) can you update this ticket with your k8s PR?

[elezar]

@kannon92 I think k8s would want to consume the v0.8.0 package / spec since this removes the dependency on the OCI runtime specification.

[kannon92]

Should we remove the call out for kubernetes then?

[bart0sh]

@kannon92

Should we remove the call out for kubernetes then?

I think it makes sense to remove. If kubernetes/kubernetes#126435 is approved, the only copy of the CDI structures is in the e2e tests: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/dra/test-driver/app/cdi.go
This can be replaced with the specs-go import at some point, but it's not that urgent.