Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitHub Actions ARM runners #218

Open
aaomidi opened this issue Aug 15, 2024 · 13 comments
Open

Support GitHub Actions ARM runners #218

aaomidi opened this issue Aug 15, 2024 · 13 comments
Labels
enhancement New feature or request

Comments

@aaomidi
Copy link

aaomidi commented Aug 15, 2024

/home/runner/work/_temp/b1d5f4e4-9e42-492a-b074-ae4e66c473a0.sh: line 1: /home/runner/bin/coveralls: cannot execute binary file: Exec format error
@afinetooth
Copy link
Member

@aaomidi We are working on this right now and hope to deliver that support this week.

You can track the issue in this issue (coverage-reporter #137) on our repo for the GitHub Actions's underlying executable, coverage-reporter. That is the executable that needs the ARM64 support.

We have had more trouble than expected with this, so if not this week, we would hope to resolve by next week sometime.

@SpayDolf
Copy link

Why the fuck did I get this email?

@SpayDolf
Copy link

image

@afinetooth
Copy link
Member

@SpayDolf, apparently because you are "a participant" (aka. following the issue):

Screenshot 2024-08-16 at 8 47 50 AM

I don't know how it happened---neither I nor @aaomidi can follow for you, and I don't see that either of us mentioned you in a comment.

But all you need to do to stop receiving notifications for this issue is remove yourself / unfollow, or unsubscribe:

Screenshot 2024-08-16 at 8 52 16 AM

@SpayDolf
Copy link

I think my device is being controlled remotely

@afinetooth
Copy link
Member

Mine also has a mind of its own.

@SpayDolf
Copy link

image

@SpayDolf
Copy link

image

@SpayDolf
Copy link

Wtf is this lol I don't even own a watch

@afinetooth afinetooth added the enhancement New feature or request label Aug 27, 2024
@aaomidi
Copy link
Author

aaomidi commented Aug 29, 2024

Did this get resolved? I see that the binary is now being built for ARM too?

@afinetooth
Copy link
Member

afinetooth commented Aug 30, 2024

Hi @aaomidi. Not quite yet. But we're close.

We've tried to cut a release with arm64 binaries twice now that we've pulled for issues discovered after the fact, so we are now adding more verification steps to our CI/CD process.

We genuinely hope to have it out today, but if not, then by Mon.

@OJFord
Copy link

OJFord commented Sep 4, 2024

@afinetooth Will we need to change anything to use it, or will it just start working, automatically using the right binary for an existing uses: coverallsapp/githubaction@v2?

@afinetooth
Copy link
Member

afinetooth commented Sep 4, 2024

Hi @OJFord.

We plan to make three (3) updates in this order and timeframe.

  1. This week - We'll cut a new release of coverage-reporter itself, which will include a new linux binary for aarch64 and provide instructions in its README for how to install and run that version.
  2. This week or next week - We'll cut new releases of our github-action and orb with new input options to specify which version of coverage-reporter to use.
  3. Next 4-6 weeks - We'll cut new releases of our github-action and orb that will automatically select the right version of coverage-reporter based on both runner OS and architecture (If possible. We have not validated this yet.)

So, until we can release (2) you won't have the option in the github-action; you would need to drop down to using the coverage-reporter directly until (2) is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants