Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make message about unchanged translation status info instead of success #3029

Open
PeterNerlich opened this issue Aug 29, 2024 · 0 comments
Open
Labels
🍼 good first issue Good for newcomers 🔨 enhancement This improves an existing feature ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Milestone

Comments

@PeterNerlich
Copy link
Collaborator

This issue is non-critical and as simple a one line change as it can get. We should reserve it for introducing newcomers to Integreat CMS and teaching about our core concepts and development and PR workflows. Please refrain from working on this if you already have an inkling about how any of this works.

Describe the Bug

In #2865, we added a bulk action to reset translations which are Currently in translation. Any of the translations that already didn't have that status before are reported to the user as a success message, since their intention has been reached. However, it is followed by another success message about the translations whose status was changed, making it a bit confusing to read.

It would be clearer if the message about the unchanged translations was only of the info type (displayed in blue).

Steps to Reproduce

  1. Go to the page tree of any region in the default language (likely German)
  2. Select a few pages
  3. Mark them as Currently in translation by scrolling to the Select bulk action dropdown below the page tree
    • Choose Export selected pages for multilingual translation (XLIFF-1.2)
    • Click Execute
    • In the resulting popup, check a target language (e.g. English)
    • Click Execute
    • Shortly, a .zip file will be downloaded. We can abort the download or delete it
  4. At the top of the page tree, switch to the target language selected before (e.g. English)
  5. Select a few pages just marked Currently in translation as well as a few that are not Currently in translation for the current target language
  6. Reset the Currently in translation status by scrolling to the Select bulk action dropdown below the page tree
    • Choose Cancel translation process
    • Click Execute
  7. See the messages displayed at the very top

Expected Behavior

An info message (blue) about pages that weren't Currently in translation, followed by a success message (green) about pages were the translation process was successfully cancelled

Actual Behavior

The first message about pages that weren't Currently in translation in the first place is also a success message and thus green, which makes it difficult to recognize both messages as separate.

Additional Information

image

@PeterNerlich PeterNerlich added 🍼 good first issue Good for newcomers ⁉️ prio: low Not urgent, can be resolved in the distant future. 🔨 enhancement This improves an existing feature ☺️ effort: low Should be doable in <4h labels Aug 29, 2024
@PeterNerlich PeterNerlich added this to the Backlog milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍼 good first issue Good for newcomers 🔨 enhancement This improves an existing feature ⁉️ prio: low Not urgent, can be resolved in the distant future. ☺️ effort: low Should be doable in <4h
Projects
None yet
Development

No branches or pull requests

1 participant