Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge methods for SimilarityHash variants #170

Open
andimiller opened this issue Oct 29, 2023 · 1 comment
Open

merge methods for SimilarityHash variants #170

andimiller opened this issue Oct 29, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@andimiller
Copy link

Problem

After adding UltraLogLog support to Apache Pinot I've been looking at adding some of the MinHash variants, but to do this I need a reliable way to merge them together when running SQL queries, or merging rows.

Solution

I'd like the SimilarityHasher interface to also have a merge method that takes two byte[] and returns a byte[] that represents the merged state.

Alternatives

@andimiller andimiller added the enhancement New feature or request label Oct 29, 2023
@oertl
Copy link
Member

oertl commented Oct 29, 2023

Merging is currently not supported. In general, the finalization steps in all similarity hashing algorithms can truncate information so that the resulting signatures cannot be further merged but require less memory. A possible solution would be to introduce an intermediate representation that can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants