Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendored Sourceror so we can use it in elixir-ls #1007

Open
robmckinnon opened this issue Oct 19, 2023 · 2 comments
Open

Vendored Sourceror so we can use it in elixir-ls #1007

robmckinnon opened this issue Oct 19, 2023 · 2 comments
Labels
question This is question rather than an issue

Comments

@robmckinnon
Copy link

The elixir-ls team have said that for sourceror to be used in elixir-ls they "need it vendored like dialyxir and jason".

When I checked, this means that the elixir-ls uses a dep branch that has all Dialyxir modules renamed to DialyxirVendored.

Would you consider creating a fork of sourceror e.g. elixir-lsp/sourceror that mirrors the latest sourceror release with all Sourceror modules renamed to VendoredSourceror?

@lukaszsamson
Copy link
Collaborator

Would you consider creating a fork of sourceror

Yes if sourceror is useful. However, currently all experimental code using it has been removed and sourceror is not a dependency

@lukaszsamson lukaszsamson added the question This is question rather than an issue label Oct 19, 2023
@robmckinnon
Copy link
Author

Thanks for saying it may be possible. I've got a draft PR I'm working on to add Exract Function refactoring support to elixir-ls, which depends on Sourceror.
#878

I'm at CodeBeam Europe now. If you happen to be here too we could discuss in person.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question This is question rather than an issue
Projects
None yet
Development

No branches or pull requests

2 participants