Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createDeprecatedModule should be striped from production builds. #132

Open
krisselden opened this issue Jun 6, 2016 · 5 comments
Open

Comments

@krisselden
Copy link
Contributor

No description provided.

@rwjblue
Copy link
Member

rwjblue commented Jun 7, 2016

Why? Having the deprecated shims present in dev builds with a deprecation, but not present in prod builds would obviously be a breaking change.

@rwjblue
Copy link
Member

rwjblue commented Jun 7, 2016

I could see doing a major bump here to drop them completely though.

@krisselden
Copy link
Contributor Author

This was still in our production build

Ember['default'].deprecate(
'Usage of `' + moduleId + '` module is deprecated, please update to `ember-resolver`.',
false,
{ id: 'ember-resolver.legacy-shims', until: '3.0.0' }
);

@rwjblue
Copy link
Member

rwjblue commented Jun 7, 2016

Right, that is because there is no infrastructure for auto-stripping these things in general. ember-cli/rfcs#50 attempts to address this. The Ember.deprecate call there will be a noop in production builds of Ember though.

@stefanpenner
Copy link
Contributor

stefanpenner commented Mar 11, 2017

@chadhietala this may be good task for you svelte tooling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants