Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@endo/errors should export the type Details #2339

Open
erights opened this issue Jul 1, 2024 · 0 comments
Open

@endo/errors should export the type Details #2339

erights opened this issue Jul 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@erights
Copy link
Contributor

erights commented Jul 1, 2024

As discussed at Agoric/agoric-sdk#9513 (comment) , in that PR in offerHandlerStorage.js

/**
 * @import {Details} from '@endo/errors'
 */

should work, but produces the type error

src/contractFacet/offerHandlerStorage.js:12:13 - error TS2305: Module '"@endo/errors"' has no exported member 'Details'.

12  * @import {Details} from '@endo/errors'
               ~~~~~~~

so instead it notes that and locally declares an equivalent Details itself, which is a maintenance hazard.

@erights erights added the bug Something isn't working label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant