Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some question about "fromCharCo" #37

Open
Clayblockunova opened this issue Nov 21, 2022 · 1 comment
Open

some question about "fromCharCo" #37

Clayblockunova opened this issue Nov 21, 2022 · 1 comment
Labels
question

Comments

@Clayblockunova
Copy link
Contributor

Currently, "fromCharCo" is defined as "from3har3o".split(3).join("C"). but I tried "from0har0o".split(0).join("C"), i's shorter and works will in Chromium. What did you think at that time?
@fasttime
Copy link
Owner

That's because of the toString optimization which makes "from3har3o" shorter than "from0har0o" when encoded as (420302320151902).toString(31). Chromium browsers don't use that definition for "fromCharCo", they use the default encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fasttime @Clayblockunova