Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility on contract read with string as return with Remix & MetaMask #55

Open
2 tasks
longfeiWan9 opened this issue Aug 19, 2024 · 1 comment
Open
2 tasks
Assignees

Comments

@longfeiWan9
Copy link
Member

longfeiWan9 commented Aug 19, 2024

Describe the pain point and how it affects builders?

  • After using remix to deploy and invoke ERC20 or ERC721 on Filecoin Calibration and mainnet, it will throw an error when invoking the read function with string as the return type. For example, name, symbol, tokenURI, etc.
  • This also affects showing tokens and NFT on MetaMask since MetaMask cannot read contract information by calling the read functions string as the return type.
  • NOTE: This was not an issue for my ERC20 deployed last year. So it might be introduced by later updates and releases of Lotus or ref-fvm. This issue was introduced with Solidity Compile 8.26 and works fine with compiler 8.20

Any proposed solutions?
It is unclear what is causing the incompatibility with Remix & MetaMask. We need to do some more research and identify what should be fixed.
This is most likely related to MCOPY which is WIP. But it would be helpful to document the support solidity compiler version in Filecoin docs so builders can avoid using incompatible solidity compilers.

*Reference:
https://filecoinproject.slack.com/archives/C0745JU645A/p1724057935888989

Tasks

@snissn
Copy link
Collaborator

snissn commented Sep 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚧 In progress
Development

No branches or pull requests

2 participants