Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect self equivocation and self-censor #567

Open
Stebalien opened this issue Aug 13, 2024 · 5 comments
Open

Detect self equivocation and self-censor #567

Stebalien opened this issue Aug 13, 2024 · 5 comments

Comments

@Stebalien
Copy link
Member

If an SP runs multiple lotus nodes, these nodes may end up equivocating. We should be able to detect this pretty quickly in F3 and censor ourselves. We probably want:

  1. GPBFT to indicate that it has seen an equivocating message from some specific participant.
  2. The client integration to watch this stream for keys it's responsible for. If it sees one, we should either bow out entirely or detect if we should continue/stop based on our peer ID? Maybe?
@Kubuxu
Copy link
Contributor

Kubuxu commented Aug 13, 2024

WAL will facilitate the knowledge of the messages we send. It could trigger tracking of IDs for which we participate. I'm not sure what the strategy should be when we detect it, but I will think about it.

@Stebalien
Copy link
Member Author

I don't think we need WAL for this. We know the identities we're signing for.

@Stebalien
Copy link
Member Author

Discussed sync:

  1. We may not catch all equivocations in GPBFT itself, need to check this.
  2. We can't just use the WAL + pubsub because we won't propagate equivocations(?).

Hm. The fact that we don't propagate them is actually a bit of an issue... really, the best answer here is to find a better way to avoid equivocations in the first place.

@Stebalien
Copy link
Member Author

Kind of a dumb solution but we could use pubsub for this by broadcasting our leases (likely on a different channel). That would "solve" this issue, albeit at the cost of sending a message to literally everyone (not a huge deal, TBH).

@Kubuxu
Copy link
Contributor

Kubuxu commented Aug 13, 2024

It also reveals the pubsub <-> minerID mapping which is not that great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants