Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit Wallpaper #448

Open
tabesin opened this issue Mar 22, 2019 · 6 comments
Open

Revisit Wallpaper #448

tabesin opened this issue Mar 22, 2019 · 6 comments

Comments

@tabesin
Copy link
Member

tabesin commented Mar 22, 2019

  • Issue type: Feature request

Short description

At present we do not have a default wallpaper explicitly set when we have a local build.

#applying wallpaper sent by meilix-generator
if [ "$wallpaper_url" != "" ]
then
wget -q $wallpaper_url -O "/usr/share/lxqt/themes/meilix/wallpaper.jpg"
fi
Of course this is not necessary when the wallpaper exists. Furthermore this logic assumes wallpaper is jpg while generator would also support png and in fact png as a lossless format is preferred for wallpapers.

Note that mere copying a file does not set the wallpaper.

@xeon-zolt
Copy link
Member

it do if we copy it to right path with the right namre

@pranav1698
Copy link

@tabesin we do have a default wallpaper, that is set by the meilix-default-theme package,
Of course this is not necessary when the wallpaper exists. Furthermore this logic assumes wallpaper is jpg while generator would also support png and in fact png as a lossless format is preferred for wallpapers.
This can be a problem, but can be solved by editing the configuration files that sets the wallpaper

@pranav1698
Copy link

Another way would, removing the default wallpaper saving the filename of the picture sent, and then editing the filename in the conf file using sed

@pranav1698
Copy link

I would like to work on this issue

@xeon-zolt
Copy link
Member

or using convert command more easy

@pranav1698
Copy link

Thanks, for the info @xeon-zolt did'nt thought of that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants