Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listing a profile already listed -> Update #9

Open
acorbi opened this issue Oct 21, 2014 · 4 comments
Open

Listing a profile already listed -> Update #9

acorbi opened this issue Oct 21, 2014 · 4 comments

Comments

@acorbi
Copy link

acorbi commented Oct 21, 2014

When receiving a request for listing, first check if the particular profile has been already listed, for that it is necessary to explore the stored files and search for the URI where the profile is stored. If a file containing that particular profile is found, it should be ovewritten. If not, new created.

@acorbi acorbi changed the title Do not allow listing a profile already listed Listing a profile already listed -> Update Oct 23, 2014
acorbi pushed a commit that referenced this issue Oct 26, 2014
@elf-pavlik
Copy link
Member

I understand you just want to fetch updated version of the profile and save it in listing?

@acorbi
Copy link
Author

acorbi commented Nov 10, 2014

@elf-pavlik Exactly, but without creating a new listing file on the directory in case that profile (about.id) was already listed. Correct me if i am wrong but i believe the actual implementation produces duplicated entries on the directory when an profile is listed for the second time.

@elf-pavlik
Copy link
Member

also added 409 Conflict 46f55ec
BTW I recalled how to ignore whitespace in github diffs 😄 https://github.com/blog/967-github-secrets

@acorbi
Copy link
Author

acorbi commented Nov 12, 2014

@elf-pavlik the directory does not expose the PUT method through its API. Shouldn't we implement it also? Currently there is no use case for it but it would be usefull in case we need to somehow modify the Listing file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants