Renaming a module in OCaml is broken

[theteachr]

Summary

Renaming a module in OCaml goofs up not only the text around, but also undo and redo actions.

Reproduction Steps

Export-1726149136353.mp4

(* a.ml *)

type a
type b

module Event = struct
  type _ t = A : a t | B : b t
end

open Event

let process : a t -> unit = function
  | A  -> ()

• hx a.ml
• Put the cursor anywhere on Event
• Space R
• Shift + A Enter
• U
• Shift + U

Helix log

No response

Platform

macOS

Terminal Emulator

iTerm

Installation Method

source

Helix Version

helix 24.3 (0c8d51e)

[the-mikedavis]

I can't reproduce this using the latest Helix master or 24.07 or 24.03 and the latest ocamllsp. I suspect this was a bug in ocamllsp with the textedits it sent for this rename.

[theteachr]

I can confirm that this is no longer an issue with the latest (1.19.0) ocaml-lsp. But I can't use the latest one for my current switch, that's using 1.17.0 of ocaml-lsp. But I also understand that this is not an issue with Helix alone.