Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the warning displayed when node_modules is detected in the application directory #736

Open
colincasey opened this issue Nov 30, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@colincasey
Copy link
Contributor

When the nodejs-npm-install buildpack runs it's build process, it checks for the presence of a node_modules folder in the application directory and emits a warning if the folder is found.

This warning makes sense when the buildpack executes on Heroku since a build is triggered by a Git push and that would indicate the user has checked in node_modules into their source control. But, when running pack locally, this warning is not required. The check should be refined to:

  • not emit the warning if the application directory is not a Git repository
  • not emit the warning if the user already has node_modules listed in their .gitignore
@colincasey colincasey added the enhancement New feature or request label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant