skipClaimRevocationCheck is defined in CredentialAtomicQueryV3 but not used?

[yushihang]

contracts/contracts/validators/CredentialAtomicQueryV3Validator.sol

Line 22 in 4c5e26d

bool skipClaimRevocationCheck;

1. skipClaimRevocationCheck is not used in CredentialAtomicQueryV3Validator

   should it be verifier with isRevocationChecked together?

2. Or should skipClaimRevocationCheck be removed from struct CredentialAtomicQueryV3

[AndriianChestnykh]

Thanks for the question @yushihang

isRevocationChecked and skipClaimRevocationCheck can't be used together, because of different logic.
As it is stated in the V3 circuit code

    // check issuer non revocation state only if we need it:
    // 1. if Sig proof is provided we need to check non revocation of authClaim always
    // AND non revocation of issuerClaim only if isRevocationChecked = 1
    // 2. if MTP proof is provided we need to check non revocation of claim only if isRevocationChecked = 1

However, the skipClaimRevocationCheck can't be removed from struct CredentialAtomicQueryV3 as in case of MTP and isRevocationChecked == false (it's public but need to set it to _setInputToIndex("isRevocationChecked", <input index>);) in the circuit, the call to the _checkClaimNonRevState() do can be omitted.

[AndriianChestnykh]

The above is something for us to check and fix.

[yushihang]

However, the skipClaimRevocationCheck can't be removed from struct CredentialAtomicQueryV3 as in case of MTP and isRevocationChecked == false

@AndriianChestnykh Thanks for your explanation，I am not sure that is there some judgement logic about skipClaimRevocationCheck in solidity code for v3? I found some code in v2 version, but not found in v3.

https://github.com/iden3/contracts/blob/07b28d7cdfe54770169ec8a213d92670085f3e49/contracts/validators/CredentialAtomicQueryV2ValidatorBase.sol#L104C1-L104C40

[vmidyllic]

isRevocationChecked is included to the query hash for v3 circuit. If user didn't do revocation check for proof generation it query hash will be not the same.
https://github.com/iden3/circuits/blob/develop/circuits/lib/utils/queryHash.circom

[AndriianChestnykh]

Thanks @vmidyllic. Yes, and in V2 it is not included into the query hash, that's why we are checking it outside ZK Verifier there.