Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal.view.home.parts.MainNeo: logo image to text positioning #5668

Open
tobiu opened this issue Aug 1, 2024 · 5 comments
Open

Portal.view.home.parts.MainNeo: logo image to text positioning #5668

tobiu opened this issue Aug 1, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@tobiu
Copy link
Collaborator

tobiu commented Aug 1, 2024

@mxmrtns @rwaters: to me the separated styling looks different than the combined svg version.

Screenshot 2024-08-01 at 20 17 30

e.g. with a negative margin-top of 8px for the text it looks closer:
Screenshot 2024-08-01 at 20 17 41

@tobiu tobiu added the enhancement New feature or request label Aug 1, 2024
@tobiu tobiu self-assigned this Aug 1, 2024
@tobiu tobiu closed this as completed Aug 1, 2024
@tobiu tobiu reopened this Aug 1, 2024
@tobiu
Copy link
Collaborator Author

tobiu commented Aug 1, 2024

for @rwaters

@tobiu tobiu closed this as completed Aug 1, 2024
@tobiu
Copy link
Collaborator Author

tobiu commented Aug 1, 2024

forgot to double-check the change on mobile.

@tobiu
Copy link
Collaborator Author

tobiu commented Aug 1, 2024

one last time...

@tobiu
Copy link
Collaborator Author

tobiu commented Aug 1, 2024

reopening again. missed the height: 10VW scaling part.

not sure if it is even possible without also scaling the h1 then.

Screenshot 2024-08-01 at 23 23 03

Screenshot 2024-08-01 at 23 23 28

@tobiu
Copy link
Collaborator Author

tobiu commented Aug 1, 2024

guess what we could do: logo & text combined svg for where it fits, separate icon svg only when above the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

1 participant