Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate nuxt-icon #181

Open
dethdkn opened this issue Jun 29, 2024 · 3 comments
Open

Deprecate nuxt-icon #181

dethdkn opened this issue Jun 29, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@dethdkn
Copy link
Contributor

dethdkn commented Jun 29, 2024

Hello! Could nuxt-icon (https://www.npmjs.com/package/nuxt-icon) be deprecated so that people don't mistakenly install it instead of @nuxt/icon (https://www.npmjs.com/package/@nuxt/icon)?

@antfu
Copy link
Member

antfu commented Jun 30, 2024

We already added a runtime warning in the latest beta of nuxt-icon. For deprecating the npm library, it would be safer to wait for a while longer.

@antfu antfu added the documentation Improvements or additions to documentation label Jun 30, 2024
@dethdkn
Copy link
Contributor Author

dethdkn commented Jun 30, 2024

@antfu I apologize for not seeing this warning. However, I believe this should be included in the latest version because most people use npm i nuxt-icon or pnpm add nuxt-icon, which installs version 0.6.10 that does not have this warning. I'm mentioning this because I noticed some colleagues mistakenly using the old version of nuxt-icon without realizing it.

I think it would make sense to release a 0.6.11 with the warning on nuxt-icon right? or set the 1.0.0-beta.7 version as the latest

Screenshot from 2024-06-29 22-41-18

@antfu
Copy link
Member

antfu commented Jun 30, 2024

Good points, just set 1.0.0-beta.7 as the latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants