linter: false positive for FunctionExpressions in unicorn/consistent-function-scoping

[DonIsaac]

This currently passes, but it should not:

function outer() {
  const inner = function inner() {}
}

See this thread for details.

[camc314]

wait i'm confused 😅

to be clear, the correct behavour here is that the following code:

function outer() {
  const inner = function inner() {}
}

should report an error (inner can be moved to the outer scope)

but with oxlint's current behaviour, it does not report an error?

---

if so, isn't this fixed by #5312, with the new test case here ? https://github.com/oxc-project/oxc/pull/5312/files#diff-8becea68b83c5a44bd998989f16fb08f3fc78f8ccfbbd95a30cc3056a6cf0edc

[DonIsaac]

[camc314]

ahhh i see - thanks

In summary:

we do not report an error for the following code:

let inner;

function outer() {
  inner = function inner() {}
}

But we should as there's no reason why the assignment couldn't be removed to the outer scope.

NOTE: when/if we implement this, we should add the following as a PASS test case:

let inner;

function foo1() {
    inner = function {}
}
function foo2() {
    inner = function {}
}

I can't think of why someone would want to do this (maybe a different logger in dev vs prod or something?), but i don't think we should report this case

[Arian94]

@camc314 would work on this.

[Arian94]

@camc314 would work on this.

@camc314 I mean myself 🍡. Assign it to me if you'd want.