Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapbox attribute control toggle, wrong styling #7082

Open
birkskyum opened this issue Aug 9, 2024 · 5 comments
Open

mapbox attribute control toggle, wrong styling #7082

birkskyum opened this issue Aug 9, 2024 · 5 comments
Assignees
Labels
bug something broken P3 not needed for current cycle

Comments

@birkskyum
Copy link
Contributor

birkskyum commented Aug 9, 2024

mapbox plots like mapbox_scattercluster appear to have issues with the little attribution icon in the lower right

Present here: https://plotly.com/python/mapbox-layers/

Present in older builds, before merging maplibre. I checked out an earlier commit, and it seems like this appear before the MapLibre merger as well locally.

Mapbox:

Screenshot 2024-08-09 at 16 04 24 Screenshot 2024-08-09 at 16 08 35 Screenshot 2024-08-09 at 16 08 30 Screenshot 2024-08-09 at 12 40 53 Screenshot 2024-08-09 at 12 42 06

MapLibre:

Screenshot 2024-08-09 at 12 41 59 Screenshot 2024-08-09 at 12 42 33

Related

@birkskyum
Copy link
Contributor Author

birkskyum commented Aug 9, 2024

Using the codepen from here i find this issue is Present from plotly.js version 2.28.0 and forward.

2.28:
Screenshot 2024-08-09 at 16 39 19
Screenshot 2024-08-09 at 16 41 21

2.27:
Screenshot 2024-08-09 at 16 39 12
Screenshot 2024-08-09 at 16 41 51

@gvwilson gvwilson added bug something broken P1 needs immediate attention labels Aug 9, 2024
@archmoj
Copy link
Contributor

archmoj commented Aug 9, 2024

Likely related to #6782.

@birkskyum
Copy link
Contributor Author

birkskyum commented Aug 9, 2024

Using the .css from mapbox-gl 1.13.3 looks like this:

Screenshot 2024-08-09 at 17 11 58 Screenshot 2024-08-09 at 17 11 54

@archmoj
Copy link
Contributor

archmoj commented Aug 27, 2024

@ndrezn Should one try to fix this new bug in mapbox?

@ndrezn ndrezn added P3 not needed for current cycle and removed P1 needs immediate attention labels Aug 27, 2024
@ndrezn
Copy link
Member

ndrezn commented Aug 27, 2024

I think this is low priority and we might not need to fix at all as we're deprecating these traces and the MapLibre traces will be unaffected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken P3 not needed for current cycle
Projects
None yet
Development

No branches or pull requests

4 participants