Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from_bytes_le_support for Integer and Point #43

Open
CPerezz opened this issue Sep 8, 2022 · 1 comment
Open

from_bytes_le_support for Integer and Point #43

CPerezz opened this issue Sep 8, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@CPerezz
Copy link
Member

CPerezz commented Sep 8, 2022

See: https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/main/zkevm-circuits/src/tx_circuit/sign_verify.rs#L395-L398 left in the last refactor.

@CPerezz CPerezz added the enhancement New feature or request label Sep 8, 2022
@CPerezz
Copy link
Member Author

CPerezz commented Jan 17, 2023

See https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/ce8c0f00a22cbb8fb491f206fd757429d3c5e1ee/zkevm-circuits/src/tx_circuit/sign_verify.rs#L319 which is what we want to remove from zkevm-circuits and move to halo2wrong.

@kilic will take a look to that within the next weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant