Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal of breaking changes in 2.x #103

Open
HZooly opened this issue Jan 16, 2020 · 9 comments
Open

Proposal of breaking changes in 2.x #103

HZooly opened this issue Jan 16, 2020 · 9 comments
Assignees
Milestone

Comments

@HZooly
Copy link
Member

HZooly commented Jan 16, 2020

Changes

Vue 3

We plan to update Vue to version 3 in order to use the new slot API.

Constant naming conventions

We will replace constants in /src/shared/constants.js syntax from uppercase to camel case to be more conventional.

VTour options refactor

Plan to pass all VTour and VStep options in a single object.

Rename stop label

Buttons labels are configurable, enabled buttons too. We will rename stopButton by finishButton in /src/shared/constants.js.

Upgrade to Popper v2

In order to fix some placement issues, improve package bundle size, and get better performances, Vue Tour 2.0 will work with Popper v2.

Proposals

If you have any idea for vue-tour v2.x, feel free to comment this issue.

@HZooly HZooly added this to the v2.x milestone Jan 16, 2020
@HZooly HZooly pinned this issue Jan 16, 2020
@clemjlt
Copy link

clemjlt commented Feb 11, 2020

Hi guys. Keep up the code work on this tool, it's definitly very useful !
I saw in one of your PR (#50) that you were suppposed to add the abiluty to highlight elements. Is this still a thing ? :)

@HZooly
Copy link
Member Author

HZooly commented Feb 12, 2020

Hey @clemjlt, thanks a lot for your support!
Yes, you can now highlight elements. This is available in version latest version (1.3.0).

@clemjlt
Copy link

clemjlt commented Feb 12, 2020

Awesome, I didn't realize you deployed that feature in V1. release, as you mentioned it was supposed to be packed with the V2. Anyway, thanks ! :)

@stripathix
Copy link

Hi @HZooly, Anu update on Vue3 Support for the vue-tour package? Really looking forward to it. Our application vue3 upgrade is almost done except for the migration of this package. Thanks for all the work.

@HZooly
Copy link
Member Author

HZooly commented Nov 20, 2020

Hi @HZooly, Anu update on Vue3 Support for the vue-tour package? Really looking forward to it. Our application vue3 upgrade is almost done except for the migration of this package. Thanks for all the work.

Hello!
@mmorainville and I are currently learning Vue 3, we expect to release Vue Tour 2 in December 😊

@stripathix
Copy link

Hi, @HZooly. Happy new year :-) . Any update on this.

@mmorainville
Copy link
Member

Hi,

A v2.x has been released! It's not compatible with Vue 3 yet (the Vue 3 will probably be vue-tour v3.x) but we have shipped two breaking changes:

  • Popper has been updated to v2.x
  • options are now all in camelCase

Our focus is now entirely on the Vue 3 version.

@stripathix
Copy link

Hi @mmorainville , any expected date for Vue3 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@mmorainville @Outpox @HZooly @stripathix @clemjlt and others