We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the regex pattern at https://github.com/ray-project/kuberay/blob/v1.1.1/ray-operator/controllers/ray/common/ingress.go#L57
Path: "/" + cluster.Name + "/(.*)"
meant that the path required a trailing slash to be routed to the cluster
example: /test/(.*)
/test/(.*)
/test
/test/
/test/#/overview
#/overview
perhaps we can improve on this regex pattern to not require the trailing slash. Maybe something like:
Path: "/" + cluster.Name + "(?:$|\/(.*))"
example: /test(?:$|/(.*))
/test(?:$|/(.*))
No response
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Search before asking
Description
the regex pattern at https://github.com/ray-project/kuberay/blob/v1.1.1/ray-operator/controllers/ray/common/ingress.go#L57
meant that the path required a trailing slash to be routed to the cluster
example:
/test/(.*)
/test
, captures nothing/test/
, captures nothing/test/#/overview
, captures#/overview
perhaps we can improve on this regex pattern to not require the trailing slash. Maybe something like:
example:
/test(?:$|/(.*))
/test
, captures nothing/test/
, captures nothing/test/#/overview
, captures#/overview
Use case
No response
Related issues
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: