Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] [Operator] remove required trailing slash on head svc ingess regex for target rewrite #2332

Open
2 tasks done
davidlhw opened this issue Aug 26, 2024 · 0 comments
Open
2 tasks done
Labels
enhancement New feature or request triage

Comments

@davidlhw
Copy link

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

the regex pattern at https://github.com/ray-project/kuberay/blob/v1.1.1/ray-operator/controllers/ray/common/ingress.go#L57

Path: "/" + cluster.Name + "/(.*)"

meant that the path required a trailing slash to be routed to the cluster

example: /test/(.*)

  • does not match /test, captures nothing
  • matches /test/, captures nothing
  • matches /test/#/overview, captures #/overview

perhaps we can improve on this regex pattern to not require the trailing slash. Maybe something like:

Path: "/" + cluster.Name + "(?:$|\/(.*))"

example: /test(?:$|/(.*))

  • matches /test, captures nothing
  • matches /test/, captures nothing
  • matches /test/#/overview, captures #/overview

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@davidlhw davidlhw added enhancement New feature or request triage labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

1 participant