-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial fontSize value is not updated and onStart/onFinish do not fire #12
Comments
hi @slapbox, I'm not sure if I can solve it, but if you can create a reproduction example by forking this Codesandbox https://codesandbox.io/s/use-fit-text-basic-example-qpo04?file=/pages/index.js it would be helpful. |
Hey @saltycrane thanks for your reply and for the great library! I've been trying like hell to make a repro case, but no such luck. Do you have any "shot in the dark" ideas about things we might look into? I've even tried poking around in the All I was able to notice from setting breakpoints in the |
I just got it to work once, but I have no idea how. I was playing around with |
hi @slapbox thanks for trying to provide a repro example and trying to debug the code. You mentioned trying to use the minified version of the source code. You could also try copy and pasting the source code here into your project so you can debug the non-minified source code. So did you see that the |
Maybe I have replicated this bug. Could not handle correctly conditioanl rendering. Added infos into a MR #29 |
I'm not sure what the issue is, because we use
useFitText
in one other place and it works, but in this other circumstance it simply defaults to the specifiedmaxFontSize
, even if that means it wraps lines. It's the same whether we use a width specified in pixels or percentages, whether we set a height on the element, whether we setoverflow: hidden
- whether we change the text or resize the window. Nothing happens under any circumstances. Any thoughts?The text was updated successfully, but these errors were encountered: