-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with module augmentation seems to be happening again #807
Comments
It would be a good idea to add a type test to this repo if this is occurring, to ensure it doesn't happen in future. I suspect the issue is that rightly or wrongly we are augmenting it in Nuxt like this: I can investigate whether we can update this in Nuxt to augment PageMeta from |
@danielroe I will open a repro, thank you. |
Hi @trc-mathieu Thanks for (re) opening an issue for this! I would love to follow along with the issue created in the Nuxt repo and then follow-up and fix the issue in our module based on the outcome. Otherwise, we can always revert the change to ensure the types work correctly again, but I would propose to wait a bit and see if any news happen 🤗 |
Let's wait for Nuxt 3.12.5 and do a version bump to close the issue |
Environment
Reproduction
You can simply clone this repository, open in VS code and navigate to
playground-authjs/pages/index.vue
and mouse over onauth
key. The type is not correctly augmented.Describe the bug
The
MiddlewareMeta
is not recognized bydefinePageMeta
macro. This issue happened in the past and it is happening to me now.The modification that was made here does fix the issue: #397 but it was rolled back by @danielroe here #582
I have this issue on other modules as well and augmenting from
#app/../pages/runtime/composables
does work.@danielroe, do you mind trying again the latest version of this repo?
using
#app
using
#app/../pages/runtime/composables
Additional context
No response
Logs
No response
The text was updated successfully, but these errors were encountered: