Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test name resolving logic #2093

Open
cptartur opened this issue Jun 19, 2023 · 4 comments
Open

Fix test name resolving logic #2093

cptartur opened this issue Jun 19, 2023 · 4 comments

Comments

@cptartur
Copy link
Member

cptartur commented Jun 19, 2023

Compiler's collect_tests adds whole paths in the filesystem to test names that are defined inline with the implementation.

e.g.
/abs/path/to/file/src::test_fib
instead of just
src::test_fib

In #1999 basic handling for this was added by just stripping the path from the name.

We should introduce the required changes to test collecting so paths are not included in the first place and remove the stripping logic.

There's a high chance this is related to #2092, so we should first resolve #2092 before starting this issue.

@MaksymilianDemitraszek
Copy link
Contributor

@cptartur Can you provide some explanation here please 🥺

@cptartur
Copy link
Member Author

@cptartur Can you provide some explanation here please 🥺

Working on it

@cptartur
Copy link
Member Author

Blocked by #2092

@piotmag769 piotmag769 added this to the Rust test runner milestone Jun 21, 2023
@cptartur
Copy link
Member Author

No longer blocked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants