Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uTP support for bitmask > 32 bits in selective ack #715

Open
kdeme opened this issue Jul 18, 2024 · 0 comments
Open

uTP support for bitmask > 32 bits in selective ack #715

kdeme opened this issue Jul 18, 2024 · 0 comments
Labels

Comments

@kdeme
Copy link
Contributor

kdeme commented Jul 18, 2024

From specification:

Selective ACK is an extension that can selectively ACK packets non-sequentially. Its payload is a bitmask of at least 32 bits, in multiples of 32 bits.

We currently only support 1x32bits, as the reference implementation does so too.

Not sure how much sense it makes to go further than this, but I've seen few times on the Portal network errors like this:

msg="Bad format of selective ack extension: extension = 0 len = 8"

Which indicate that other clients do allow more, and that it also occurs. Not sure if this is a healthy situation however, but that is another question.

@kdeme kdeme added the uTP label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant