Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WC] Add countdown pill to sign dialogs #16314

Open
Tracked by #16312
alexjba opened this issue Sep 11, 2024 · 2 comments · May be fixed by #16349
Open
Tracked by #16312

[WC] Add countdown pill to sign dialogs #16314

alexjba opened this issue Sep 11, 2024 · 2 comments · May be fixed by #16349

Comments

@alexjba
Copy link
Contributor

alexjba commented Sep 11, 2024

Add the countdown pill

Figma

image
image

Spec here: WalletConnect/walletconnect-monorepo#1851

@alexjba alexjba changed the title Countdown pill [QML][WC] Add countdown pill Sep 11, 2024
@alexjba alexjba changed the title [QML][WC] Add countdown pill [QML][WC] Add countdown pill to sign dialogs Sep 11, 2024
@alexjba alexjba changed the title [QML][WC] Add countdown pill to sign dialogs [WC] Add countdown pill to sign dialogs Sep 11, 2024
@alexjba alexjba added this to the 2.32.0 Beta milestone Sep 11, 2024
@caybro caybro self-assigned this Sep 11, 2024
@caybro
Copy link
Member

caybro commented Sep 11, 2024

@alexjba do we already have the corresponding notification in place?

image

Should the little timer component be covered here, or in separate ticket? That said, I'm not totally convinced the timer itself should be part of the countdown pill here, wdyt?

@alexjba
Copy link
Contributor Author

alexjba commented Sep 11, 2024

@alexjba do we already have the corresponding notification in place?

image

Should the little timer component be covered here, or in separate ticket? That said, I'm not totally convinced the timer itself should be part of the countdown pill here, wdyt?

We don't have the notification. Not totally convinced either. Maybe it would be nice to have the visual component as a base class and the timer logic in the upper component. Just in case we find different use cases for it.

@caybro caybro modified the milestones: 2.32.0 Beta, 2.31.0 Beta Sep 13, 2024
caybro added a commit that referenced this issue Sep 16, 2024
- show countdown until which the sign (WalletConnect and Swap) dialogs
expire
- after expiration, hide the Reject/Sign buttons and display a plain
Close button
- make the dialogs non-closable by clicking outside or pressing Esc; the
user has to explicitely click some of the footer buttons

Fixes #16327
Fixes #16314
@caybro caybro linked a pull request Sep 16, 2024 that will close this issue
3 tasks
caybro added a commit that referenced this issue Sep 19, 2024
- show countdown until which the sign (WalletConnect and Swap) dialogs
expire
- after expiration, hide the Reject/Sign buttons and display a plain
Close button
- make the dialogs non-closable by clicking outside or pressing Esc; the
user has to explicitely click some of the footer buttons

Fixes #16327
Fixes #16314
caybro added a commit that referenced this issue Sep 19, 2024
- show countdown until which the sign (WalletConnect and Swap) dialogs
expire
- after expiration, hide the Reject/Sign buttons and display a plain
Close button
- make the dialogs non-closable by clicking outside or pressing Esc; the
user has to explicitely click some of the footer buttons

Fixes #16327
Fixes #16314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Code Review
Development

Successfully merging a pull request may close this issue.

2 participants