From 0ba19a25752f2978b89aaa805ccaa76d9dcc09ed Mon Sep 17 00:00:00 2001
From: Valentin Palkovic <valentin@chromatic.com>
Date: Fri, 6 Sep 2024 15:06:45 +0200
Subject: [PATCH] Remove build-sandboxes job in CircleCI

---
 .circleci/config.yml | 96 +++++++++++++-------------------------------
 1 file changed, 28 insertions(+), 68 deletions(-)

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 3e5c0b499cc6..e7a5cf371b90 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -307,10 +307,23 @@ jobs:
           name: Enable Corepack
           command: sudo corepack enable yarn
       - run:
-          name: Creating Sandboxes
-          command: yarn task --task sandbox --template $(yarn get-template --cadence << pipeline.parameters.workflow >> --task sandbox) --no-link --start-from=never --junit
+          name: Build Sandboxes
+          command: yarn task --task build --template $(yarn get-template --cadence << pipeline.parameters.workflow >> --task build) --no-link --start-from=sandbox --junit
+          environment:
+            STORYBOOK_TELEMETRY_URL: "http://localhost:6007/event-log"
+      - run:
+          name: Verifying Telemetry
+          command: |
+            TEMPLATE=$(yarn get-template --cadence << pipeline.parameters.workflow >> --task build)
+            if [[ $TEMPLATE != bench/* ]]
+            then
+              yarn jiti ./event-log-checker.ts build $TEMPLATE
+            fi
+          working_directory: scripts
       - report-workflow-on-failure:
-          template: $(yarn get-template --cadence << pipeline.parameters.workflow >> --task sandbox)
+          template: $(yarn get-template --cadence << pipeline.parameters.workflow >> --task build)
+      - store_test_results:
+          path: test-results
       - persist_to_workspace:
           root: .
           paths:
@@ -337,47 +350,6 @@ jobs:
           template: $(yarn get-template --cadence << pipeline.parameters.workflow >> --task smoke-test)
       - store_test_results:
           path: test-results
-  build-sandboxes:
-    parameters:
-      parallelism:
-        type: integer
-    executor:
-      class: large
-      name: sb_node_22_browsers
-    parallelism: << parameters.parallelism >>
-    steps:
-      - git-shallow-clone/checkout_advanced:
-          clone_options: "--depth 1 --verbose"
-      - attach_workspace:
-          at: .
-      - run:
-          name: Starting Event Collector
-          command: yarn jiti ./event-log-collector.ts
-          working_directory: scripts
-          background: true
-      - run:
-          name: Building Sandboxes
-          command: yarn task --task build --template $(yarn get-template --cadence << pipeline.parameters.workflow >> --task build) --no-link --start-from=never --junit
-          environment:
-            STORYBOOK_TELEMETRY_URL: "http://localhost:6007/event-log"
-      - run:
-          name: Verifying Telemetry
-          command: |
-            TEMPLATE=$(yarn get-template --cadence << pipeline.parameters.workflow >> --task build)
-            if [[ $TEMPLATE != bench/* ]]
-            then
-              yarn jiti ./event-log-checker.ts build $TEMPLATE
-            fi
-          working_directory: scripts
-      - report-workflow-on-failure:
-          template: $(yarn get-template --cadence << pipeline.parameters.workflow >> --task build)
-      - store_test_results:
-          path: test-results
-      - persist_to_workspace:
-          root: .
-          paths:
-            - sandbox/*/bench/*.json
-            - sandbox/*/storybook-static
   test-runner-production:
     parameters:
       parallelism:
@@ -702,18 +674,14 @@ workflows:
           parallelism: 14
           requires:
             - build
-      - build-sandboxes:
-          parallelism: 14
-          requires:
-            - create-sandboxes
       - chromatic-sandboxes:
           parallelism: 11
           requires:
-            - build-sandboxes
+            - create-sandboxes
       - e2e-production:
           parallelism: 9
           requires:
-            - build-sandboxes
+            - create-sandboxes
       - e2e-dev:
           parallelism: 2
           requires:
@@ -721,7 +689,7 @@ workflows:
       - test-runner-production:
           parallelism: 9
           requires:
-            - build-sandboxes
+            - create-sandboxes
       - vitest-integration:
           parallelism: 5
           requires:
@@ -729,7 +697,7 @@ workflows:
       - bench:
           parallelism: 5
           requires:
-            - build-sandboxes
+            - create-sandboxes
       - test-portable-stories:
           requires:
             - build
@@ -768,18 +736,14 @@ workflows:
           parallelism: 20
           requires:
             - build
-      - build-sandboxes:
-          parallelism: 20
-          requires:
-            - create-sandboxes
       - chromatic-sandboxes:
           parallelism: 17
           requires:
-            - build-sandboxes
+            - create-sandboxes
       - e2e-production:
           parallelism: 15
           requires:
-            - build-sandboxes
+            - create-sandboxes
       - e2e-dev:
           parallelism: 2
           requires:
@@ -787,7 +751,7 @@ workflows:
       - test-runner-production:
           parallelism: 15
           requires:
-            - build-sandboxes
+            - create-sandboxes
       - vitest-integration:
           parallelism: 5
           requires:
@@ -801,7 +765,7 @@ workflows:
       - bench:
           parallelism: 5
           requires:
-            - build-sandboxes
+            - create-sandboxes
       # TODO: reenable once we find out the source of flakyness
       # - test-runner-dev:
       #     parallelism: 4
@@ -835,18 +799,14 @@ workflows:
       # - smoke-test-sandboxes: # disabled for now
       #     requires:
       #       - create-sandboxes
-      - build-sandboxes:
-          parallelism: 38
-          requires:
-            - create-sandboxes
       - chromatic-sandboxes:
           parallelism: 35
           requires:
-            - build-sandboxes
+            - create-sandboxes
       - e2e-production:
           parallelism: 33
           requires:
-            - build-sandboxes
+            - create-sandboxes
       - e2e-dev:
           parallelism: 2
           requires:
@@ -854,7 +814,7 @@ workflows:
       - test-runner-production:
           parallelism: 33
           requires:
-            - build-sandboxes
+            - create-sandboxes
       - vitest-integration:
           parallelism: 11
           requires:
@@ -886,7 +846,7 @@ workflows:
       - bench:
           parallelism: 5
           requires:
-            - build-sandboxes
+            - create-sandboxes
 
       # TODO: reenable once we find out the source of flakyness
       # - test-runner-dev: