Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Releasing majors/minors fails to sync version files at the end of the workflow #29089

Open
JReinhold opened this issue Sep 11, 2024 · 0 comments
Assignees
Labels
bug build Internal-facing build tooling & test updates

Comments

@JReinhold
Copy link
Contributor

JReinhold commented Sep 11, 2024

Describe the bug

Releasing major/minors fails at the end of the CI workflow because it tries to sync the version.json files from next-release to main - but main is already up-to-date at this point, so there's nothing to push. This is a false-negative, everything is in order, it just needs to not attempt that last sync because it has already happened with a force-push in a previous step.

Reproduction link

https://github.com/storybookjs/storybook/actions/runs/10812502523/job/29994286479

Reproduction steps

See the workflow run for the 8.3.0 release:
https://github.com/storybookjs/storybook/actions/runs/10812502523/job/29994286479

@JReinhold JReinhold added bug build Internal-facing build tooling & test updates labels Sep 11, 2024
@JReinhold JReinhold self-assigned this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build Internal-facing build tooling & test updates
Projects
None yet
Development

No branches or pull requests

1 participant