Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiring soon calculation assumes static quarter length #53

Open
asakusuma opened this issue Jul 27, 2021 · 0 comments
Open

Expiring soon calculation assumes static quarter length #53

asakusuma opened this issue Jul 27, 2021 · 0 comments

Comments

@asakusuma
Copy link
Contributor

// 91 days in a quarter, 24hrs per day, 60 minutes per hour, 60 seconds per hour, 1000 milliseconds per sec

Not all quarters are the exact same length. Quarters with two 31 day months will be longer than quarters with one 31 day month. This results in some calculations being off by a day. Will be worse with the quarter with February.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant