Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading from the socket tends to block. #48

Open
otrho opened this issue Nov 2, 2020 · 0 comments
Open

Reading from the socket tends to block. #48

otrho opened this issue Nov 2, 2020 · 0 comments

Comments

@otrho
Copy link
Contributor

otrho commented Nov 2, 2020

Much of the response reading/parsing code uses a default timeout of 20 seconds (from session.d: Options.timeout) but I'm seeing the code just blocking if we try to read when there's no data.

Right now e.g., in append() when reading a continue response but getting a TRYCREATE it doesn't parse properly and blocks. I'll fix that specifically but there are probably many places in the reading/parsing which could block in a similar way (even with a timeout, which is strange.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant