Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow return the id of the imported documents #55

Open
rpinzon opened this issue Feb 20, 2024 · 3 comments
Open

Allow return the id of the imported documents #55

rpinzon opened this issue Feb 20, 2024 · 3 comments

Comments

@rpinzon
Copy link

rpinzon commented Feb 20, 2024

Description

According to the documentation it's possible to configure the import response to return the ingested document's id in the response. To achieve this you can use the return_id parameter.

The import_ function allows us to provide an instance of ImportDocumentsParameters. However, this class does not provide a way to configure the flag return_id.

Steps to reproduce

Check the methods of ImportDocumentsParameters class.

Expected Behavior

I expect to be able to configure the return_id flag using either a setter or a builder method within the ImportDocumentsParameters class.

For example:

Using setter method:

ImportDocumentsParameters params = new ImportDocumentsParameters();
params.setReturnId(true);

Using builder method:

ImportDocumentsParameters params = new ImportDocumentsParameters().returnId(true);

Actual Behavior

It's not possible to configure the return_id flag.

Metadata

Typesense Version: 0.25.2

OS: N/A

@shinusuresh
Copy link
Contributor

@kishorenc Looks like an issue with API spec. I don't see return_id in openapi spec.

@kishorenc
Copy link
Member

Yes this needs to be added to the openapi spec so that it works with the Java client.

@stargazer33
Copy link
Contributor

yes, I need it too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants