Content-Type header not being set from plugin

[ngregrichardson]

Hi everyone! Loving the DX of this so far, but I'm running into some issues. I'd like to catch any errors that are thrown in any route, so I've made a plugin to handle them:

import httpStatus from "http-status";
import { APIException } from "~/responses/exceptions/api.exception";
import { BadRequestException } from "~/responses/exceptions/badRequest.exception";

export default defineNitroPlugin((nitro) => {
  nitro.hooks.hook("error", async (error, { event }) => {
    let response: any = {
      isSuccess: false,
      code: httpStatus.INTERNAL_SERVER_ERROR,
      status: httpStatus[httpStatus.INTERNAL_SERVER_ERROR],
      timestamp: new Date().toISOString(),
      message: "Something went wrong, please try again later.",
    };
    if (error instanceof APIException) {
      response = {
        isSuccess: error.isSuccess,
        code: error.code,
        status: error.status,
        timestamp: error.timestamp,
        message: error.message,
      };

      if (error instanceof BadRequestException) {
        response.errors = error.errors;
      }
    }

    event.node.res.statusCode = response.code;

    event.node.res.end(JSON.stringify(response));

    event._handled = true;
  });
});

I imagined that ending the response and marking the event as handled would work, but when this is run it completes successfully (sends what I'd expect to the frontend), but it also logs these two errors:

[nitro] [unhandledRejection] Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client
    at new NodeError (node:internal/errors:405:5)
    at ServerResponse.setHeader (node:_http_outgoing:652:11)
    at setResponseHeader (file:///C:/Users/ngreg/Documents/ZIKI/ziki-api/node_modules/.pnpm/[email protected]/node_modules/h3/dist/index.mjs:716:18)
    at errorHandler (file:///C:/Users/ngreg/Documents/ZIKI/ziki-api/.nitro/dev/index.mjs:1837:5)
    at Object.onError (file:///C:/Users/ngreg/Documents/ZIKI/ziki-api/.nitro/dev/index.mjs:2007:14)
    at Server.toNodeHandle (file:///C:/Users/ngreg/Documents/ZIKI/ziki-api/node_modules/.pnpm/[email protected]/node_modules/h3/dist/index.mjs:1847:27)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  code: 'ERR_HTTP_HEADERS_SENT'
}
Error while capturing another error TypeError: Cannot read properties of undefined (reading 'node')
    at file:///C:/Users/ngreg/Documents/ZIKI/ziki-api/.nitro/dev/index.mjs:599:11
    at file:///C:/Users/ngreg/Documents/ZIKI/ziki-api/node_modules/.pnpm/[email protected]/node_modules/hookable/dist/index.mjs:55:57
    at file:///C:/Users/ngreg/Documents/ZIKI/ziki-api/node_modules/.pnpm/[email protected]/node_modules/hookable/dist/index.mjs:55:47
    at Array.map (<anonymous>)
    at parallelTaskCaller (file:///C:/Users/ngreg/Documents/ZIKI/ziki-api/node_modules/.pnpm/[email protected]/node_modules/hookable/dist/index.mjs:55:28)
    at Hookable.callHookWith (file:///C:/Users/ngreg/Documents/ZIKI/ziki-api/node_modules/.pnpm/[email protected]/node_modules/hookable/dist/index.mjs:198:20)
    at Hookable.callHookParallel (file:///C:/Users/ngreg/Documents/ZIKI/ziki-api/node_modules/.pnpm/[email protected]/node_modules/hookable/dist/index.mjs:191:17)
    at Object.captureError (file:///C:/Users/ngreg/Documents/ZIKI/ziki-api/.nitro/dev/index.mjs:1990:27)
    at _captureError (file:///C:/Users/ngreg/Documents/ZIKI/ziki-api/.nitro/dev/index.mjs:447:17)
    at process.<anonymous> (file:///C:/Users/ngreg/Documents/ZIKI/ziki-api/.nitro/dev/index.mjs:452:16)

I can't find much more information about this, any ideas of something I'm doing wrong or is this a bug?

[ngregrichardson]

I managed to muddle my way through that issue, but now the Content-Type is being sent as "text/html" and the status code isn't being set either. Nothing I do (calling setHeader, setResponseHeader, etc.) can change them.

import httpStatus from "http-status";
import { APIException } from "~/responses/exceptions/api.exception";
import { BadRequestException } from "~/responses/exceptions/badRequest.exception";

export default defineNitroPlugin((nitro) => {
  nitro.hooks.hook("error", async (error, { event }) => {
    if (error.cause instanceof APIException) {
      error = error.cause;
    }

    let response: any = {
      isSuccess: false,
      code: httpStatus.INTERNAL_SERVER_ERROR,
      status: httpStatus[httpStatus.INTERNAL_SERVER_ERROR],
      message: "Something went wrong, please try again later.",
    };

    if (error instanceof APIException) {
      response.id = event.context.requestId;
      response.isSuccess = error.isSuccess;
      response.code = error.code;
      response.status = error.status;
      response.message = error.message;

      if (error instanceof BadRequestException) {
        response.errors = error.errors;
      }
    }

    setResponseStatus(event, response.code);

    send(event, JSON.stringify(response), "application/json");
  });
});

[ngregrichardson]

Solved all of this by doing:

event.respondWith(
      new Response(JSON.stringify(response), {
        status: response.code,
        headers: {
          "Content-Type": "application/json",
        },
      })
    );