Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KiCad toolbar colors are incorrect #102

Open
covertneko opened this issue Mar 2, 2023 · 4 comments
Open

KiCad toolbar colors are incorrect #102

covertneko opened this issue Mar 2, 2023 · 4 comments

Comments

@covertneko
Copy link

KiCad's project window and toolbars have incorrect background colors in both light and dark mode.

Originally reported here for Catppuccin, which is based on this theme.

GTK theme set to Colloid-Purple-Dark:

image

GTK theme set to Colloid-Purple-Light:

image

GTK theme set to Adwaita:

image

As mentioned in the issue linked above, as far as I can tell this with the background-color property from here is the cause.

I'm not sure what the implications of changing this would be, but I was able to fix my theme locally by commenting out the background-color property in the button rule in gtk-dark.css.

Colloid-Purple-Dark with above property commented out:

image

@vinceliuice
Copy link
Owner

I don't know why KiCad use button's background color as window's background color and can not have alpha in color, if I change the button's color all gtk button's style will changed, I think this is more like a app issue

@okawo80085
Copy link

This is a really weird issue that pretty much only KiCad has, it picks the background color for its toolbars from the most random attributes, it appears to be a wxWigets issue or something, the discussion on the kicad issue tracker is useless finger pointing.
It doesn't affect just this theme, im on Orchis for example, have the same issue, and the only way for me to fix it was to set the button background color to my dark theme's background color, after that it finally started looking normal (no visible issues with anything else btw, like buttons didn't start looking black all of a sudden).
So the possible fix on the user side (that at least works for me) is to set your desired toolbar background color here before you install your theme.

@mp-strachan
Copy link

Hi @okawo80085, I am also using Orchis with the same KiCad issue. I've looked around for the button background style, but don't seem to see it. I assumed it would be in gtk-3.0/gtk-dark.css. Can you shed some more light on which element you updated? Thanks in advance!

@okawo80085
Copy link

Hi @mp-strachan, i have a fork with a patch for that, i used on my machines, you can just cherry pick that commit if you want or clone the repo and install it like normal Orchis
https://github.com/okawo80085/Orchis-theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants