Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: isolate examples to remove friction with root folder #12

Open
arnaudambro opened this issue Sep 17, 2024 · 1 comment
Open

Comments

@arnaudambro
Copy link

I have some problems on my own to run vite-pwa on my project, so I try to see if your exampe is working properly

but I use yarn on my projects, and here I'm "forced"to use pnpm

and when I solve this problem (isolating the pwa-simple-pw and touch yarn.lock) then I have

> dev
> VIRTUAL_PWA_MODULE=true remix vite:dev

sh: remix: command not found

I think it would be GREAT if the examples where working isolates, with anyone choosing their own package manager they're used to

I could make a PR if you were interested

@userquin
Copy link
Member

We're using pnpm as package manager and we enable shell-emulator in .npmrc file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants