-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Panes for AppFlowy #3337
base: main
Are you sure you want to change the base?
Conversation
…eat-panes-2312
…eat-panes-2312
…eat-panes-2312
@squidrye I have merged the editor optimization into the main branch. You can now rebase the latest main branch and test the performance of multiple editor's windows again. |
…eat-panes-2312
8610457
to
09811ef
Compare
...lowy_flutter/lib/plugins/document/presentation/editor_plugins/base/built_in_page_widget.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/workspace/application/panes/panes_cubit/panes_cubit.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/workspace/application/panes/panes_service.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/workspace/application/tabs/tabs.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/lib/workspace/presentation/home/home_stack.dart
Outdated
Show resolved
Hide resolved
fc9ccb8
to
b72d4ca
Compare
615ad01
to
2524c8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've cleaned up a bit
frontend/appflowy_flutter/integration_test/board/board_row_test.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/integration_test/database_calendar_test.dart
Outdated
Show resolved
Hide resolved
frontend/appflowy_flutter/integration_test/board/board_row_test.dart
Outdated
Show resolved
Hide resolved
acbdbf0
to
563b362
Compare
1411e6d
to
c152e1e
Compare
what blocks this PR from merging? |
Due to the sheer size and complexity of the work here, I requested a secondary review from @LucasXu0 , but it was in the middle of the work on mobile, so it was pushed down in priority for a while. |
…eat-panes-2312
31a6dca
to
9b5f834
Compare
Thanks @squidrye for the merge 🙏 |
Feature Preview
AwesomeScreenshot-9_1_2023.1.35.57PM.mp4
#2312 This PR targets implementation of multi-panes
cc @Xazin
#3237 Reopening this PR, had to delete my older fork because I had pushed private code due to local git misconfiguration 😢
PR Checklist
Todos