Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset individual shortcut #5756

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

MayurSMahajan
Copy link
Collaborator

@MayurSMahajan MayurSMahajan commented Jul 17, 2024

Solves: #5684

  • Added a new method to the cubit with appropriate error handling
  • Added cubit tests and an integration test to test the fix
  • Added appropriate localization.

Feature Preview

Here is a feature preview:

individual_shortcut.mp4

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

github-actions bot commented Jul 17, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 108 warning contribute (via Fink 🐦)

@MayurSMahajan MayurSMahajan requested a review from Xazin July 17, 2024 18:31
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.13%. Comparing base (c122f0a) to head (5fa42da).
Report is 333 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5756       +/-   ##
===========================================
- Coverage   86.74%   75.13%   -11.61%     
===========================================
  Files         217      239       +22     
  Lines        5032     6464     +1432     
  Branches      831     1041      +210     
===========================================
+ Hits         4365     4857      +492     
- Misses        561     1555      +994     
+ Partials      106       52       -54     
Flag Coverage Δ
appflowy_web_app 75.13% <ø> (-11.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xazin
Copy link
Collaborator

Xazin commented Jul 22, 2024

Should we change the opacity (eg. 70%), change cursor to default, and change the tooltip to "Keybinding is already the default", when the keybinding is already the one it would be after an eventual reset?

@MayurSMahajan
Copy link
Collaborator Author

Yes, that sounds right. On it!

@Xazin
Copy link
Collaborator

Xazin commented Aug 5, 2024

Hey @MayurSMahajan , I've added the behavior I spoke about previously for disabling the button when the keybinding is already the default.

@Xazin Xazin requested a review from LucasXu0 August 5, 2024 16:10
@MayurSMahajan
Copy link
Collaborator Author

Oh Thanks!

@MayurSMahajan
Copy link
Collaborator Author

@LucasXu0 what is stopping this PR from getting merged?

@LucasXu0
Copy link
Collaborator

@LucasXu0 what is stopping this PR from getting merged?

Nothing. Give me some time to review it.

@MayurSMahajan
Copy link
Collaborator Author

@Xazin @LucasXu0 Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants